fix: resolve RN 0.85 web warnings and upgrade Expo SDK 56#4958
Open
azizbecha wants to merge 1 commit into
Open
fix: resolve RN 0.85 web warnings and upgrade Expo SDK 56#4958azizbecha wants to merge 1 commit into
azizbecha wants to merge 1 commit into
Conversation
azizbecha
changed the title
|
Hey @azizbecha, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
satya164
requested changes
May 24, 2026
Comment on lines
+93
to
+95
| tintColor={color} | ||
| fadeDuration={0} | ||
| style={{ width: size, height: size, tintColor: color }} | ||
| style={{ width: size, height: size }} |
Member
There was a problem hiding this comment.
Where are you seeing warnings about tintColor? I only see warnings for resizeMode and shadow*
Comment on lines
+48
to
+75
| it('uses boxShadow instead of shadow props on web headers', () => { | ||
| const originalPlatform = Platform.OS; | ||
| Platform.OS = 'web'; | ||
|
|
||
| try { | ||
| const { getByTestId } = render( | ||
| <mockSafeAreaContext.SafeAreaProvider> | ||
| <Appbar.Header elevated> | ||
| <Appbar.Content title="Examples" /> | ||
| </Appbar.Header> | ||
| </mockSafeAreaContext.SafeAreaProvider> | ||
| ); | ||
|
|
||
| const styles = StyleSheet.flatten( | ||
| getByTestId('appbar-header-root-layer').props.style | ||
| ); | ||
|
|
||
| expect(styles).toMatchObject({ | ||
| boxShadow: '0px 2px 6px rgba(0, 0, 0, 0.3)', | ||
| }); | ||
| expect(styles).not.toHaveProperty('shadowColor'); | ||
| expect(styles).not.toHaveProperty('shadowOpacity'); | ||
| expect(styles).not.toHaveProperty('shadowOffset'); | ||
| expect(styles).not.toHaveProperty('shadowRadius'); | ||
| } finally { | ||
| Platform.OS = originalPlatform; | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
Remove this test. Tests shouldn't test implementation details.
To test for deprecated styles an appropriate test would be to actually check whether there are console warnings. Though I think that's not really necessary.
Comment on lines
+21
to
+39
| it('passes image-specific props without using deprecated style keys', () => { | ||
| const tintColor = 'tomato'; | ||
| const source = { uri: 'https://picsum.photos/700' }; | ||
| const { getByTestId } = render( | ||
| <Icon | ||
| source={source} | ||
| size={ICON_SIZE} | ||
| color={tintColor} | ||
| testID="image-icon" | ||
| /> | ||
| ); | ||
| const imageIcon = getByTestId('image-icon'); | ||
| const styles = StyleSheet.flatten(imageIcon.props.style); | ||
|
|
||
| expect(imageIcon.props.resizeMode).toBe('contain'); | ||
| expect(imageIcon.props.tintColor).toBe(tintColor); | ||
| expect(styles).not.toHaveProperty('resizeMode'); | ||
| expect(styles).not.toHaveProperty('tintColor'); | ||
| }); |
Comment on lines
+20
to
+44
| it('renders web shadows with boxShadow instead of shadow props', () => { | ||
| const originalPlatform = Platform.OS; | ||
| Platform.OS = 'web'; | ||
|
|
||
| try { | ||
| const { getByTestId } = render( | ||
| <Surface elevation={5} testID="surface-test"> | ||
| {null} | ||
| </Surface> | ||
| ); | ||
|
|
||
| const styles = StyleSheet.flatten( | ||
| getByTestId('surface-test').props.style | ||
| ); | ||
|
|
||
| expect(styles).toMatchObject({ | ||
| boxShadow: '0px 8px 12px rgba(0, 0, 0, 0.3)', | ||
| }); | ||
| expect(styles).not.toHaveProperty('shadowColor'); | ||
| expect(styles).not.toHaveProperty('shadowOpacity'); | ||
| expect(styles).not.toHaveProperty('shadowOffset'); | ||
| expect(styles).not.toHaveProperty('shadowRadius'); | ||
| } finally { | ||
| Platform.OS = originalPlatform; | ||
| } |
Comment on lines
+37
to
+41
| const getShadowColor = (shadowColor: ColorValue, shadowOpacity: number) => | ||
| color(typeof shadowColor === 'string' ? shadowColor : 'black') | ||
| .alpha(shadowOpacity) | ||
| .rgb() | ||
| .string(); |
Member
There was a problem hiding this comment.
If a non-string is received on Web, it should throw an error as it's a user error instead of defaulting to black.
| const getBoxShadowValue = (elevation: number, shadowColor: ColorValue) => | ||
| `0px ${shadowLayers[0].height[elevation]}px ${ | ||
| shadowLayers[0].shadowRadius[elevation] | ||
| }px ${getShadowColor(shadowColor, elevation ? 0.3 : 0)}`; |
Member
There was a problem hiding this comment.
for interpolations, this is doing color manipulation multiple times even though the color is not changing. Move this to the web branch and assign it to a variable, then reuse the variable in the shadow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing